From 954e7f179030e108ad0ccc6b561e4fc4a424ca04 Mon Sep 17 00:00:00 2001 From: emilkowalski Date: Sun, 13 Oct 2024 16:33:08 +0200 Subject: [PATCH 1/2] fix long press error --- src/index.tsx | 34 ++++++++++++++++++---------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/src/index.tsx b/src/index.tsx index e128e90..ebcc34a 100644 --- a/src/index.tsx +++ b/src/index.tsx @@ -25,8 +25,8 @@ import { usePositionFixed } from './use-position-fixed'; export interface WithFadeFromProps { /** - * Array of numbers from 0 to 100 that corresponds to % of the screen a given snap point should take up. - * Should go from least visible. Example `[0.2, 0.5, 0.8]`. + * Array of numbers from 0 to 100 that corresponds to % of the screen a given snap point should take up. + * Should go from least visible. Example `[0.2, 0.5, 0.8]`. * You can also use px values, which doesn't take screen height into account. */ snapPoints: (number | string)[]; @@ -38,8 +38,8 @@ export interface WithFadeFromProps { export interface WithoutFadeFromProps { /** - * Array of numbers from 0 to 100 that corresponds to % of the screen a given snap point should take up. - * Should go from least visible. Example `[0.2, 0.5, 0.8]`. + * Array of numbers from 0 to 100 that corresponds to % of the screen a given snap point should take up. + * Should go from least visible. Example `[0.2, 0.5, 0.8]`. * You can also use px values, which doesn't take screen height into account. */ snapPoints?: (number | string)[]; @@ -52,7 +52,7 @@ export type DialogProps = { children?: React.ReactNode; open?: boolean; /** - * Number between 0 and 1 that determines when the drawer should be closed. + * Number between 0 and 1 that determines when the drawer should be closed. * Example: threshold of 0.5 would close the drawer if the user swiped for 50% of the height of the drawer or more. * @default 0.25 */ @@ -64,12 +64,12 @@ export type DialogProps = { onOpenChange?: (open: boolean) => void; shouldScaleBackground?: boolean; /** - * When `false` we don't change body's background color when the drawer is open. + * When `false` we don't change body's background color when the drawer is open. * @default true */ setBackgroundColorOnScale?: boolean; /** - * Duration for which the drawer is not draggable after scrolling content inside of the drawer. + * Duration for which the drawer is not draggable after scrolling content inside of the drawer. * @default 500ms */ scrollLockTimeout?: number; @@ -78,12 +78,12 @@ export type DialogProps = { */ fixed?: boolean; /** - * When `true` only allows the drawer to be dragged by the `` component. + * When `true` only allows the drawer to be dragged by the `` component. * @default false */ handleOnly?: boolean; /** - * When `false` dragging, clicking outside, pressing esc, etc. will not close the drawer. + * When `false` dragging, clicking outside, pressing esc, etc. will not close the drawer. * Use this in comination with the `open` prop, otherwise you won't be able to open/close the drawer. * @default true */ @@ -91,14 +91,14 @@ export type DialogProps = { onDrag?: (event: React.PointerEvent, percentageDragged: number) => void; onRelease?: (event: React.PointerEvent, open: boolean) => void; /** - * When `false` it allows to interact with elements outside of the drawer without closing it. + * When `false` it allows to interact with elements outside of the drawer without closing it. * @default true */ modal?: boolean; nested?: boolean; onClose?: () => void; /** - * Direction of the drawer. Can be `top` or `bottom`, `left`, `right`. + * Direction of the drawer. Can be `top` or `bottom`, `left`, `right`. * @default 'bottom' */ direction?: 'top' | 'bottom' | 'left' | 'right'; @@ -113,21 +113,21 @@ export type DialogProps = { */ disablePreventScroll?: boolean; /** - * When `true` Vaul will reposition inputs rather than scroll then into view if the keyboard is in the way. + * When `true` Vaul will reposition inputs rather than scroll then into view if the keyboard is in the way. * Setting it to `false` will fall back to the default browser behavior. * @default true when {@link snapPoints} is defined */ repositionInputs?: boolean; /** - * Disabled velocity based swiping for snap points. - * This means that a snap point won't be skipped even if the velocity is high enough. + * Disabled velocity based swiping for snap points. + * This means that a snap point won't be skipped even if the velocity is high enough. * Useful if each snap point in a drawer is equally important. * @default false */ snapToSequentialPoint?: boolean; container?: HTMLElement | null; /** - * Gets triggered after the open or close animation ends, it receives an `open` argument with the `open` state of the drawer by the time the function was triggered. + * Gets triggered after the open or close animation ends, it receives an `open` argument with the `open` state of the drawer by the time the function was triggered. * Useful to revert any state changes for example. */ onAnimationEnd?: (open: boolean) => void; @@ -958,7 +958,9 @@ export const Content = React.forwardRef(function ( }} onContextMenu={(event) => { rest.onContextMenu?.(event); - handleOnPointerUp(lastKnownPointerEventRef.current); + if (lastKnownPointerEventRef.current) { + handleOnPointerUp(lastKnownPointerEventRef.current); + } }} /> ); From 83715c6d439fc6937989148061567c3da52c088d Mon Sep 17 00:00:00 2001 From: emilkowalski Date: Sun, 13 Oct 2024 16:34:04 +0200 Subject: [PATCH 2/2] types --- src/context.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/context.ts b/src/context.ts index 6678d64..557b9c7 100644 --- a/src/context.ts +++ b/src/context.ts @@ -16,7 +16,7 @@ interface DrawerContextValue { keyboardIsOpen: React.MutableRefObject; snapPointsOffset: number[] | null; snapPoints?: (number | string)[] | null; - activeSnapPointIndex?: number; + activeSnapPointIndex?: number | null; modal: boolean; shouldFade: boolean; activeSnapPoint?: number | string | null;