Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Simple page transition causes overflow-x [video] #562

Open
mirague opened this issue Mar 17, 2017 · 2 comments
Open

Bug: Simple page transition causes overflow-x [video] #562

mirague opened this issue Mar 17, 2017 · 2 comments

Comments

@mirague
Copy link

mirague commented Mar 17, 2017

I've implemented a simple fade transition from a games listing to a simple game. Whenever I transition there's a flashing horizontal scrollbar appearing, which doesn't appear when using a normal {{outlet}}. I've tried disabling all of my css selectors and keeping the elements in the target route to a minimum, even to the point of removing almost anything.

application.hbs

{{top-bar}}

<main>
  {{liquid-outlet}}
</main>

transitions.js

export default function () {
  this.transition(
    this.fromRoute('games'),
    this.toRoute('game'),
    this.use('fade', { duration: 400 }),
    this.reverse('fade', { duration: 400 })
  );
}

Video (x2 slow motion)

https://www.youtube.com/watch?v=4r3nsceDnTI
Pay close attention to the horizontal bar that briefly appears on the transition.

workaround

A hack around this jumpy behaviour is:

body {
  overflow-x: hidden;
}

But this is obviously not a lasting solution. Any thoughts?

@winne42
Copy link

winne42 commented Sep 15, 2020

@mirague Which version of Liquid Fire did you use? Is this still an issue or can this issue be closed?

@mirague
Copy link
Author

mirague commented Sep 15, 2020

Haven't been using Ember for years now - feel free to close it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants