No Protocols Passed to window.WebSocket

[abdalrahmanSrour]

Hello and thanks for this great JSON-RPC 2.0 implementation

Anyway i was looking around your implementation and found that in Client APIs the "protocols" is not being passed to "window.WebSocket".
Here at line 26

rpc-websockets/src/lib/client/websocket.browser.ts

Lines 22 to 27 in ea4a76b

	constructor(address: string, options: {}, protocols?: string | string[])
	{
	super()
	this.socket = new window.WebSocket(address, protocols)

because protocols is always no passed from here at line 93

rpc-websockets/src/lib/client/websocket.browser.ts

Lines 91 to 94 in ea4a76b

	export default function(address: string, options: IWSClientAdditionalOptions)
	{
	return new WebSocketBrowserImpl(address, options)
	}

I think we can add the protocols as new argument.

[mkozjak]

Thanks, @abdalrahmanSrour, sounds good. Please provide a PR including tests and I’ll be more than happy to take a look and include it!

[mkozjak]

Any updates on this one, @abdalrahmanSrour?

[mkozjak]

@abdalrahmanSrour - ping!

[abdalrahmanSrour]

Pong!

Sorry for not replying, actually i moved to implement new WS client.
Anyway if i had sometime soon i will try to do it.

[mkozjak]

@abdalrahmanSrour: Using another lib? Which one?