Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for having a language per review #200

Open
ftyers opened this issue Apr 19, 2018 · 2 comments
Open

Add support for having a language per review #200

ftyers opened this issue Apr 19, 2018 · 2 comments

Comments

@ftyers
Copy link

ftyers commented Apr 19, 2018

I'm a non-monolingual user. I want to submit reviews in different languages. I want to review places in multiple languages and maybe even in different languages for the same place.

It should be possible to submit reviews in any language I want, according to ISO language codes. And I should be the one in control of determining which language my review is submitted in.

My choice of language used for expression shouldn't be curated by some randomised (or seemingly randomised) list of "popular languages".

@eloquence
Copy link
Owner

This is possible right now. Any review can have an arbitrary number of translations, and any user can change back and forth between languages as they see fit. When you change the UI language, the software also assumes (and notifies you to this effect) that you are now authoring content in that language. If you write a review in English, then switch to German, then edit it, you are effectively creating a German translation (the English version remains available).

Here's an example of a review in English and Esperanto:

https://lib.reviews/sojo?useLang=eo
https://lib.reviews/sojo?useLang=en

This is admittedly not very intuitive at all, so suggestions how to make it more obvious/usable are gratefully appreciated. :)

@phtan
Copy link

phtan commented Nov 11, 2018

I am not very familiar with the flow of making a review on said website - but suppose there were a drop-down list, near the text-editor, allowing the user to choose from all available languages.

Functionally speaking, after the user selects a language from the list and clicks the 'submit' button after typing his review, the language of the UI would be set to his chosen language, and a review would be created for him in that language.

It seems that you have the functionality to implement the above imaginary drop-down list; it seems to me it is simply a matter of doing some work for the user (so that, for example, he doesn't have to take the step of changing the language of the UI - even though the UI-language does get changed for him, eventually, if you follow my line of thought)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants