Add driver view #300
Add driver view #300
Conversation
There was a problem hiding this comment.
Very excited about this, fantastic work! Left a couple of inline comments.
For the overarching design direction, in looking at other driver managers it looks like maybe a better way to list drivers would be to have a toplevel item that represents the device and then a list of radio buttons that represent the available driver options. For example here's Ubuntu drivers:
| Object ( | ||
| icon: new ThemedIcon ("application-x-firmware"), | ||
| title: _("Drivers"), | ||
| description: _("Additional drivers provided by device manufacturers can improve performance.") |
There was a problem hiding this comment.
I think we can copy the description text from Installer:
| description: _("Additional drivers provided by device manufacturers can improve performance.") | |
| description: _("Broadcom® Wi-Fi adapters, NVIDIA® graphics, and some virtual machines may not function properly without additional drivers.") |
|
|
||
| construct { | ||
| var none_placeholder = new Granite.Placeholder (_("No drivers available")) { | ||
| description = _("Your system doesn't need any additional drivers."), |
There was a problem hiding this comment.
We usually try to avoid "you" forms for localization. I think also "system" is usually more used to refer to the operating system software, and "device" is usually more used to refer to the computer hardware
| description = _("Your system doesn't need any additional drivers."), | |
| description = _("This device doesn't need any additional drivers."), |
| xalign = 0 | ||
| }; | ||
|
|
||
| var install_button = new Gtk.Button.with_label (installed ? _("Installed") : _("Install")) { |
There was a problem hiding this comment.
I think it might be more appropriate to use a radio here to make it more clear that this is a mutually exclusive selection
|
@danirabbit ok I created a different branch (#309) with radio buttons. It (or rather settings daemon side of it) has a larger surface for errors so it should be tested carefully. |
|
Closing since we merged the other version |
UI side of elementary/settings-daemon#132
I modeled this after the firmware view. Any suggestions are welcome
Unfortunately I think we can't do anything about the icons :(