Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a difference between code commits and translation commits #38

Open
snowparrot opened this issue Jan 24, 2021 · 2 comments
Open

Make a difference between code commits and translation commits #38

snowparrot opened this issue Jan 24, 2021 · 2 comments
Labels
Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix. Priority: Medium Should be addressed when time allows Status: Confirmed Verified by someone other than the reporter

Comments

@snowparrot
Copy link

Problem

Many commits are just translation commits. If you want to see, if there was a commit on code base,
we need make a distinction.

Proposal

Some proposals:
Instead showing the amount of commits, count the code commits and the translation commits seperately.

Prior Art

@btkostner
Copy link
Contributor

We will want to modify this line to exclude comments with the email [email protected] and [email protected]

https://github.com/elementary/releases/blob/master/release.py#L43

@snowparrot
Copy link
Author

Though I am happy about your fast and positive response I think counting translation commit still has a purpose ( like for minor updates)

@lewisgoddard lewisgoddard added Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix. Hacktoberfest Used in the month of October for good issues for new contributors Priority: Medium Should be addressed when time allows Status: Confirmed Verified by someone other than the reporter and removed Hacktoberfest Used in the month of October for good issues for new contributors labels Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bitesize Small, self-contained issue. Good for newcomers, and/or should be an easy fix. Priority: Medium Should be addressed when time allows Status: Confirmed Verified by someone other than the reporter
Projects
None yet
Development

No branches or pull requests

3 participants