-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #22: Don't mark release as critical if it's less than a month old #33
Conversation
lewisgoddard
commented
Apr 7, 2020
•
edited
Loading
edited
- Fixes Don't mark release as critical if it's less than a month old #22: Don't mark release as critical if it's less than a month old
- Get now and release_date as integers.
- Stop marking recent releases with warnings and criticals.
- Warn over 50 commits, even with recent releases.
Get now and release_date as integers, and stop marking recent releases with warnings and criticals.
I was looking at this in smarter-critical-badge, but something I was thinking about was trying to share more meaning behind the why of the status. |
Ah, this was based on work I was doing for my fork and I already have a timeago field there which kind of handles that. https://releases.eustasy.org/ |
@lewisgoddard yeah by I think there can still be a disconnect between, "well this one has 50 commits and is red, why is this one with 72 commits not?" or whatever the exact numbers are. I guess I want to think about if we can convey statuses in a better way. :) Not-fully-thought-out designing incoming… Maybe something like:
And then each might have qualifying data below that for context. I.e.: Recent Release |
@cassidyjames Want to take another look at this? Haven't styled it, just semantically works like you wanted. |
@cassidyjames @danrabbit @davidmhewitt There are outstanding review requests but no activity for quite some time. Maybe it should be converted to draft or closed if there is little chance of it getting merged? I do not have rights to do this. |