Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode Icons #1293

Open
NaomiX3 opened this issue Jun 24, 2024 · 2 comments
Open

Dark Mode Icons #1293

NaomiX3 opened this issue Jun 24, 2024 · 2 comments
Labels
Status: Confirmed Verified by a bug manager and planned to be worked on

Comments

@NaomiX3
Copy link

NaomiX3 commented Jun 24, 2024

Problem

When on dark mode the icons appear a lil bit too bright, specially at night, that can cause eye fatigue for some people.

Proposal

I think having a different set of icons or just darken the current ones for dark mode would be nicer on the eyes (just like the new IOS 18) :)

Prior Art (Optional)

ayedapt-light-and-dark

@danirabbit
Copy link
Member

Hey thanks for filing this feature request! I don't think this would be difficult to do for the system icons and we could solve issues like #985, #951, and #853 by providing a dark icon theme that inherits the default icon theme and then switching those in settings-daemon

I'm not sure about how to go about solving this for app icons however. Probably that should be pursued upstream in Freedesktop.org here: https://gitlab.freedesktop.org/xdg/xdg-specs/-/issues

@danirabbit danirabbit added this to OS 9 Jun 24, 2024
@danirabbit danirabbit moved this to Needs Discussion in OS 9 Jun 24, 2024
@danirabbit danirabbit added the Status: Confirmed Verified by a bug manager and planned to be worked on label Jun 24, 2024
@wpkelso
Copy link
Member

wpkelso commented Jul 29, 2024

I'd love to see what I can do with this. I have a couple of questions though:

I'm not sure about how to go about solving this for app icons however.

Could application icons not be solved (at least as a stop-gap) in a similar way with an overlay theme? It wouldn't do the dynamic update across all icons that iOS does, but it would solve the issue for eOS specific apps.

...by providing a dark icon theme that inherits the default icon theme and then switching those in settings-daemon

Would implementing this as an overlay theme break other overlay themes that would be expecting to fallback to the default theme? If that's the case, would it make sense to instead generate a full light theme and a dark theme, then switch between those in settings-daemon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Confirmed Verified by a bug manager and planned to be worked on
Projects
Status: Needs Discussion
Development

No branches or pull requests

3 participants