Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the daily build fails, previous successful builds should still be shown #98

Open
jlnr opened this issue Jun 19, 2023 · 1 comment
Open

Comments

@jlnr
Copy link
Member

jlnr commented Jun 19, 2023

Problem

The daily build was failing for a few days due to a failing patch: https://github.com/elementary/os/actions/runs/5300799983/jobs/9594557628#step:4:610

This caused the section about daily amd64 builds to be completely hidden from the page. There was no indication of the error, and it was impossible to know about previous builds.

Proposal

If the current build fails, the archive of previous builds should still be accessible. Maybe even an indication that the builds are currently outdated because of build failures.

Prior Art (Optional)

The Pinebook/Pi 4 builds show an archive of previous builds, the same could have been offered for the amd64 build.

@jlnr
Copy link
Member Author

jlnr commented Jun 19, 2023

Hmmm...it seems that this is already what should happen: https://github.com/elementary/builds/blob/9a98c9a11d7c4a7be1df548acd6e8ab8509671ed/pages/downloads.vue#L125C5-L131

I will try to look into this some more so that I can ideally provide a patch myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant