Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OS updates #2111

Merged
merged 8 commits into from
Feb 11, 2024
Merged

Remove OS updates #2111

merged 8 commits into from
Feb 11, 2024

Conversation

danirabbit
Copy link
Member

This doesn't completely remove packagekit because we use it for UbuntuDrivers

@danirabbit danirabbit requested a review from a team February 6, 2024 23:57
@danirabbit
Copy link
Member Author

@leolost2605 I don't think runtime updates should be asking for a reboot right? Should we remove the restart notification completely?

@leolost2605
Copy link
Member

@danirabbit I can't comment on runtime updates but AFAIK the only thing that would need a reboot are drivers and with elementary/settings-daemon#132 they can be removed as well so we might just remove it know 🤷

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now but I think we can remove even a bit more? For example we could just make packagekit return in cache refresh since it's not needed for ubuntu drivers i think?

src/Core/UpdateManager.vala Outdated Show resolved Hide resolved
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leolost2605 leolost2605 merged commit 48598e9 into master Feb 11, 2024
4 checks passed
@leolost2605 leolost2605 deleted the danirabbit/rm-osupdates branch February 11, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants