Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maker-dmg): remove extraneous properties from MakerDMGConfig #3761

Merged
merged 7 commits into from
Nov 30, 2024

Conversation

tanishqkancharla
Copy link
Contributor

@tanishqkancharla tanishqkancharla commented Nov 16, 2024

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

  • Remove the required appPath key and optional out path from MakerDMGOptions because it always gets overridden.

Closes #3712

@tanishqkancharla tanishqkancharla requested a review from a team as a code owner November 16, 2024 23:20
@tanishqkancharla tanishqkancharla changed the title make appPath optional make appPath optional in MakerDMG options Nov 16, 2024
@erickzhao erickzhao changed the title make appPath optional in MakerDMG options fix(maker-dmg): remove unnecessary config values from types Nov 30, 2024
@erickzhao erickzhao changed the title fix(maker-dmg): remove unnecessary config values from types fix(maker-dmg): remove extraneous properties from MakerDMGConfig Nov 30, 2024
@erickzhao erickzhao added this pull request to the merge queue Nov 30, 2024
Merged via the queue into electron:main with commit e142715 Nov 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MakerDMG config requiring appPath even thought it is never used in typescript project
2 participants