-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[all] RFC: Add dependencies to Gemfile #288
base: staging
Are you sure you want to change the base?
Conversation
add rake as a workaround to a bundler bug
this is already handled by bundler-cache
Can you clarify what you mean by hard dependency? I run lich on linux without gtk kind of. I run in docker containers that are built with gtk (all the necessary packages, then the gem is installed, then the packages are all purged - this keeps image size WAY down). So while gtk gem is there, it never really gets used, and in fact if something tries to use it, it fails. |
I think of sqlite as the only real hard dependency. Gtk is entirely optional. |
What makes you say GTK3 is a hard dependency on linux? I play without GTK on linux... |
If you try to run Lich without the gtk3 gem installed on Linux it fails with a message saying you need to install it. |
|
I think this is a very good proposal, if for now it will only be utilized by devs. The current weird way we distribute Lich means we cannot actually take advantage of a Gemfile for the most part, but it might make for a much better DevEx |
+1 I just ran into this while trying to package Lich for NixOS. In your latest RC there is a Gemfile so I took a crack at it and ran into a couple of issues.
I'm not sure but that seems like a dependency that isn't specified either in your Gemfile or in sqlite3's (which would surprise me). Based on the timing of these comments and the newer nature of your Gemfiles I assume that it's still a WIP but wanted to express some interest in sorting this out so I can help get the package setup on Nixpkgs. EDIT: |
I'd like some input here. sqlite3 is a hard dependency, so it can definitely be added here. gtk3 is a hard dependency on Linux, but appears to not be on windows. I think using bundler to install the gem is the way to go. Are there many people using Lich on Windows without GTK3?