-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: introduce opinionated api #33
Draft
efcasado
wants to merge
34
commits into
main
Choose a base branch
from
feat-tesla-ecto
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efcasado
force-pushed
the
feat-tesla-ecto
branch
5 times, most recently
from
May 11, 2024 10:40
83ba622
to
22140d1
Compare
efcasado
force-pushed
the
feat-tesla-ecto
branch
2 times, most recently
from
May 11, 2024 13:59
3be4c0c
to
147387b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
Req
andSaxaboom
byTesla
andEcto
while introducing a more opinionated API that abstracts away some of the complexity of the underlying Betradar's UOF API.Now, all functionality is defined in
noun
modules (eg.Sports
,Fixtures
).Action Log
defmodule
for nested schemas!
variants