Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change query cancellation mechanism #1640

Open
skreborn opened this issue Dec 8, 2024 · 0 comments
Open

Change query cancellation mechanism #1640

skreborn opened this issue Dec 8, 2024 · 0 comments
Labels
new feature Something new is needed

Comments

@skreborn
Copy link

skreborn commented Dec 8, 2024

By default, queries have a timeout, which means every query has to complete in a fairly arbitrary amount of time.

While settings the default timeout to a larger value or disabling it entirely is possible (and quite easy), I propose that a default of no timeout in addition to a manual cancellation method would be ultimately better.

Zenoh could, in this case, provide timeout as merely a convenience wrapper around executing the cancellation process itself after a given period has elapsed without a reply, while remaining unopinionated about the default mechanism.

Cancellation tokens (like the one in tokio-util) could be a nice way to manage this.

I understand that this would be a breaking change, but luckily only on the API side, not the protocol.

@skreborn skreborn added the new feature Something new is needed label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Something new is needed
Projects
None yet
Development

No branches or pull requests

1 participant