Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Membership status publication #49

Open
JEnoch opened this issue Oct 14, 2021 · 2 comments
Open

Membership status publication #49

JEnoch opened this issue Oct 14, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@JEnoch
Copy link
Member

JEnoch commented Oct 14, 2021

The zenoh-bridge-dds are discovering and supervising each other via a Group Management algorithm. This feature is configurable via:

  • --group-member-id <ID>: This option allows to set a custom identifier for the bridge, that will be used in group membership algorithm (if not specified, the zenoh UUID is used).
  • --group-lease <Duration>: The lease duration (in seconds) used in group membership algorithm

I would be useful for the user if the bridge publishes the group events:

  • when a remote bridge joins the group (i.e. it's discovered)
  • when a remote bridge explicitly leaves the group
  • when a remote bridge has its lease expired (i.e. connectivity loss or bridge crash)
@JEnoch
Copy link
Member Author

JEnoch commented Oct 14, 2021

Such publication can be made on zenoh, on DDS or on both.

A publication on zenoh has almost no cost if there is no subscriber. I suggest to not make this configurable and to always do the publication on zenoh (key and value to be defined).

On the other hand, a publication on DDS has a cost: the declaration of a DDS Writer that implies discovery messages. Moreover, user might want to configure the DDS topic name to possibly match with the ROS2 design (topic name prefixed with rt/ and possibly an additional namespace). I suggest to make the this configurable via and option:

  • --group-dds-topic-pub <Topic_Name>: The name of the DDS topic on which membership events (join, leave, lease expired) are published. If not set, no publication on DDS is made.

@Mallets Mallets added the enhancement New feature or request label Apr 4, 2022
@Mallets
Copy link
Member

Mallets commented Apr 4, 2022

@JEnoch has there been any progress on this aspect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants