Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: issues in NotificationsTest.cpp #101

Open
debruce opened this issue Aug 15, 2024 · 0 comments
Open

clang-tidy: issues in NotificationsTest.cpp #101

debruce opened this issue Aug 15, 2024 · 0 comments

Comments

@debruce
Copy link
Contributor

debruce commented Aug 15, 2024

  1. do not use namespace using-directives; use using-declarations instead (line 22)
  2. destructor probably needs override at line 36
  3. magic numbers used at lines 47, 63, 85, 109, 130
  4. Complains about 'auto source_filter = source;' being a needless copy at line 65, similar complaints at line 111
  5. invalid case style for num_messages (line 66), notificationSource (line 68 and 114), num_messages (line 112)
  6. not initialized: rx_queue_mtx (line 73), message (line 94), rx_queue_mtx (line 118)
  7. Bogus if-then-else complaint hidden inside a gtest macro (linee 81, 89, 126, 134)
  8. is unused: message (line 86 and 131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant