Copy local signature from MethodHandleNatives.resolve #20700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
force-pushed
the
fix_20189
branch
2 times, most recently
from
e59bbaf to
74b5d5e
Compare
hangshao0
reviewed
Nov 28, 2024
theresa-m
changed the title
theresa-m
force-pushed
the
fix_20189
branch
2 times, most recently
from
8211b66 to
ec0efc6
Compare
hangshao0
reviewed
Dec 2, 2024
|
Adding @fengxue-IS as reviewer. |
fengxue-IS
reviewed
Dec 2, 2024
theresa-m
force-pushed
the
fix_20189
branch
3 times, most recently
from
8e4c875 to
c98038d
Compare
Signed-off-by: Theresa Mammarella <[email protected]>
|
Jenkins test sanity.functional,extended plinuxval jdknext |
|
Jenkins test sanity amac jdk21 |
|
Jenkins test sanity.functional,extended alinux jdk11 |
hangshao0
approved these changes
Dec 3, 2024
keithc-ca
reviewed
Dec 3, 2024
Comment on lines
+1326
to
1327
| true, | ||
| true); |
There was a problem hiding this comment.
These arguments should be TRUE, not true or false: the argument types are BOOLEAN, not bool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the case mentioned in #20189 (comment)
sig1inj9bcv_checkClassLoadingConstraintsForSignatureshould be copied butsig2does not need to be copied. I added an additional boolean for each signature and it is only set to false if the signature is found in a class memory segment.Related to: #20189