Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech-debt: fix deprecated warnings in build script #2485

Open
agliga opened this issue Nov 4, 2024 · 0 comments
Open

tech-debt: fix deprecated warnings in build script #2485

agliga opened this issue Nov 4, 2024 · 0 comments
Assignees
Milestone

Comments

@agliga
Copy link
Contributor

agliga commented Nov 4, 2024

Fix these

Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

   ┌──> src/sass/button/button.scss
10 │       border-radius: var(--btn-border-radius, calc($button-height-regular / 2));
   │       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> src/sass/mixins/private/_button-mixins.scss
21 │ ┌     &--fixed-height {
22 │ │         height: 40px;
23 │ │     }
   │ └─── nested rule
   ╵
    src/sass/button/button.scss 10:5         @import
    src/sass/bundles/skin-headless.scss 9:9  @import
    src/sass/bundles/skin-full.scss 10:9     @import
    src/routes/+layout.style.scss 9:9        root stylesheet

Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

   ┌──> src/sass/button/button.scss
10 │       border-radius: var(--btn-border-radius, calc($button-height-regular / 2));
   │       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> src/sass/mixins/private/_button-mixins.scss
25 │ ┌     &--truncated {
26 │ │         @include btn-truncate();
27 │ │
28 │ │         height: 40px;
29 │ │     }
@agliga agliga added this to the 18.5.0 milestone Nov 4, 2024
@agliga agliga self-assigned this Nov 4, 2024
@agliga agliga added this to eBayUI Nov 4, 2024
@agliga agliga modified the milestones: 18.5.0, 18.6.0 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

1 participant