Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebay-menu-button: labelWithPrefixAndIcon causes key warnings #350

Open
mikehobi opened this issue Jun 26, 2024 · 1 comment
Open

ebay-menu-button: labelWithPrefixAndIcon causes key warnings #350

mikehobi opened this issue Jun 26, 2024 · 1 comment
Labels
tech debt The update/fix/change is overdue

Comments

@mikehobi
Copy link

Hello!

When I'm using <EbayMenuButton>, with prefixLabel and text, I get key warnings in the dev console:

browser-init.tsx:11 Warning: Each child in a list should have a unique "key" prop.

Check the render method of `EbayMenuButton`. See https://fb.me/react-warning-keys for more information.
    in span (created by EbayMenuButton)
    in EbayMenuButton (created by InventoryFilter)
    in InventoryFilter (created by InventoryGrid)
    in section (created by InventoryGrid)
    in div (created by InventoryGrid)
    in InventoryGrid (created by MainPage)
    in div (created by ModuleContainer)
    in ModuleContainer (created by MainPage)
    in section (created by MainPage)
    in MainPage
browser-init.tsx:11 Warning: Each child in a list should have a unique "key" prop. See https://fb.me/react-warning-keys for more information.
    in span (created by EbayButtonText)
    in EbayButtonText (created by EbayButtonExpand)
    in span (created by EbayButtonCell)
    in EbayButtonCell (created by EbayButtonExpand)
    in EbayButtonExpand (created by EbayButton)
    in button (created by EbayButton)
    in EbayButton (created by EbayButton)
    in EbayButton (created by EbayMenuButton)
    in span (created by EbayMenuButton)
    in EbayMenuButton (created by InventoryFilter)
    in InventoryFilter (created by InventoryGrid)
    in section (created by InventoryGrid)
    in div (created by InventoryGrid)
    in InventoryGrid (created by MainPage)
    in div (created by ModuleContainer)
    in ModuleContainer (created by MainPage)
    in section (created by MainPage)
    in MainPage

I've narrowed it down to the labelWithPrefixAndIcon function withing ebay-menu-button/menu-button.tsx

Versions

"react": "^16.12.0"
"@ebay/ui-core-react": "^6.2.1"

@darkwebdev
Copy link
Collaborator

thanks we'll take a look!

@darkwebdev darkwebdev added the tech debt The update/fix/change is overdue label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt The update/fix/change is overdue
Projects
None yet
Development

No branches or pull requests

2 participants