[gommon][log] log.Error does not panic nor exit

[at15]

@gaocegege I saw several usage of log.Error , I am not sure if you are just logging it or you want to the program to exit directly, if it's the latter one, you should call log.Panic or log.Fatal. log.Error is based on logrus where it is a log message with a red prefix.

• https://github.com/dyweb/dy-bot/blob/master/pkg/event/issue/types.go#L42
• https://github.com/dyweb/dy-bot/blob/master/pkg/gh/client.go#L26

switch actionType {
case "closed":
	if err := p.processEventClosed(issue); err != nil {
		return err
	}
default:
	log.Errorf("action type %s is not supported yet", actionType)
}
return nil

func GetGitHubClient() *Client {
	if gitHubClient == nil {
		log.Error("GitHubClient is not initialized")
	}
	return gitHubClient
}

[gaocegege]

I do not want to panic when i am using errorf. Actually it is a long running service and should never be stopped even there is an error.

[at15]

@gaocegege I think for the GetGitHubClient one, it should panic instead of logging as error, it would cause panic eventually when the caller use the returned null pointer as a client.

[gaocegege]

Yeah, that's cool.