Only export core types from messaging #1188
Draft
+94
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for content-scope-scripts failed.
|
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Sat, 02 Nov 2024 11:06:20 GMT Android
File has changed ChromeFile has changed Chrome-mv3File has changed FirefoxFile has changed Integration
File has changed Windows
File has changed Apple
File has changed |
shakyShane
requested review from
mgurgel,
a team,
kzar,
ladamski,
franfaccin and
jonathanKingston
as code owners
shakyShane
commented
Nov 1, 2024
| @@ -82,7 +81,7 @@ describe('Android', () => { | |||
| featureName, | |||
| env: 'development' | |||
| }) | |||
| const messaging = new Messaging(messageContextA, config) | |||
| const messaging = config.intoMessaging(messageContextA) | |||
There was a problem hiding this comment.
By reversing the dependency here, it prevents the Messaging constructor from having to know about every transport
shakyShane
commented
Nov 1, 2024
| */ | ||
| export class Messaging { | ||
| /** | ||
| * @param {MessagingContext} messagingContext | ||
| * @param {MessagingConfig} config | ||
| * @param {MessagingTransport} transport |
There was a problem hiding this comment.
the significant change here, is that we directly take a transport now, preventing the core library needing to know about them all ahead of time
shakyShane
force-pushed
the
11-01-only_export_core_types_from_messaging
branch
from
366aeb5
to
9c0d928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/0/1201614831475344/1208567543316316/f
Description
Alter the messaging API to prevent having to import all implementations (and them ending up in resulting bundles)
Note
This doesn't improve special pages just yet, but it is a big improvement for the injected side
Testing Steps
Checklist
Please tick all that apply: