Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Permissions: Code Clean up #5363

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Dec 6, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1208702063802241/f

Description

This PR finishes cleaning up the code from Site Permissions.

  • Moves strings to site permissions module
  • Moves Activities to site permissions module
  • Removes old LocationPermissions

Steps to test this PR

Navigate to Site Permissions screen and smoke test it

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@malmstein malmstein force-pushed the feature/david/12-06-site_permissions_code_clean_up_and_translation branch from ee66181 to 0b52d65 Compare December 6, 2024 14:20
@malmstein malmstein marked this pull request as ready for review December 6, 2024 14:31
@malmstein malmstein requested a review from nalcalag as a code owner December 6, 2024 14:31
@malmstein malmstein force-pushed the feature/david/12-06-site_permissions_code_clean_up_and_translation branch from 6b930f3 to 9c7b1a2 Compare December 9, 2024 20:10
malmstein and others added 24 commits December 10, 2024 21:36
Translate strings-common-ui to values-fi
Translate strings-common-ui to values-sv
Translate strings-common-ui to values-tr
Translate strings-common-ui to values-hr
Translate strings-common-ui to values-et
Translate strings-common-ui to values-nb
Translate strings-common-ui to values-es
Translate strings-common-ui to values-pt
Translate strings-common-ui to values-cs
Translate strings-common-ui to values-el
Translate strings-common-ui to values-da
Translate strings-common-ui to values-bg
Translate strings-common-ui to values-fr
Translate strings-common-ui to values-de
Translate strings-common-ui to values-pl
Translate strings-common-ui to values-sl
Translate strings-common-ui to values-ro
Translate strings-common-ui to values-ru
Translate strings-common-ui to values-nl
Translate strings-common-ui to values-it
Translate strings-common-ui to values-lt
Translate strings-common-ui to values-hu
Translate strings-common-ui to values-lv
Translate strings to values-es
Translate strings to values-ro
Translate strings to values-tr
Translate strings to values-sk
Translate strings to values-ru
Translate strings to values-et
Translate strings to values-it
Translate strings to values-pl
Translate strings to values-bg
Translate strings to values-lv
Translate strings to values-fi
Translate strings to values-sl
Translate strings to values-nl
Translate strings to values-hr
Translate strings to values-hu
Translate strings to values-nb
Translate strings to values-sv
Translate strings to values-da
Translate strings to values-el
Translate strings to values-fr
Translate strings to values-lt
Translate strings to values-pt
Translate strings to values-cs
@malmstein malmstein force-pushed the feature/david/12-06-site_permissions_code_clean_up_and_translation branch from 51f3191 to 35b8977 Compare December 10, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants