GHA: Notify Mattermost #5274
Draft
GHA: Notify Mattermost #5274
+138
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmstein
force-pushed
the
feature/david/11-14-gha_notify_mattermost
branch
from
980c67a
to
24a1de6
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+39
to
+53
| run: | | ||
| ./send_chat_message.sh '${{env.emoji_info}}'" Release task created https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}" | ||
|
|
||
| - name: Send Release tag created | ||
| run: | | ||
| ./send_chat_message.sh '${{env.emoji_info}}'" Release task created https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}" | ||
|
|
||
| - name: Send Release task created message | ||
| run: | | ||
| echo -n '::notice title=Inputs::' && echo '${{ toJson(inputs) }}' | sed -z 's_\n_%0A_g'; echo | ||
| message="Release ${{ env.APP_VERSION }} task created" | ||
| message+="See https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}" | ||
| ./send_chat_message.sh '${{env.emoji_info}}'" ${message}" | ||
| ./send_chat_message.sh '${{env.emoji_info}}'" Release task created https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}" |
There was a problem hiding this comment.
There appear to be several duplicate message sends in this workflow. Specifically:
- The
Send Release tag createdstep sends the exact same message as the previous step - The final step sends the "Release task created" message twice
Consider consolidating these into single message sends to avoid duplicate notifications in the chat channel. This will keep the notifications clean and meaningful for the team.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
| token: ${{ secrets.GT_DAXMOBILE }} | ||
| fetch-depth: 0 | ||
| ref: feature/david/11-14-gha_notify_mattermost |
There was a problem hiding this comment.
The ref parameter is hardcoded to a specific feature branch, which will prevent this workflow from running on other branches. Consider removing this line to allow the workflow to execute on the current branch where it's triggered.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Description
Steps to test this PR
Feature 1
UI changes