Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvement #115

Open
thibpoullain opened this issue Dec 19, 2018 · 3 comments
Open

Documentation improvement #115

thibpoullain opened this issue Dec 19, 2018 · 3 comments

Comments

@thibpoullain
Copy link

Hi guys,

Thanks for your work ! Could it be possible to write a little bit more documentation (exemples, etc.), because it's very very light. Hard and almost impossible to get in without exemples on google.

Thx again ! :)

@nicolas-besnard
Copy link

hey @thibpoullain,

Can you provide links that helped you? I'm sure it'll help other people!

Also, what kind of example do you think might help others?

@thibpoullain
Copy link
Author

Hi @nicolas-besnard,

Sure, I gather the links and I'll post them here !

@wilsonch
Copy link

wilsonch commented Jan 11, 2019

👍
Would appreciate some documentation around how to upgrade from 0.12.1 to 0.13.0
Changes did not seem to be backward compatible.

e.g. this minimal example worked in 0.12.1

###
class MyOp include Dry::Transaction::Operation
  def call(input)
    Success(input)
  rescue
    Failure('Failure in my_op')
  end
end

###
module MyContainer
  class << self
    def container
      { my_op: MyOp.new }
    end
  end
end

###
class MyTransaction
  include Dry::Transaction(container: MyContainer.container)

  step :my_op
end

In 0.13.0, we get: Dry::Transaction::MissingStepError (Definition for step +my_op+ is missing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants