Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Presage] Some extracted archive members have trailing spaces #53

Open
dressupgeekout opened this issue Jul 20, 2020 · 0 comments
Open
Labels
ANNOYANCE Not a bug *per se*, but still worth changing ROCKETT Relates to the main Rockett series of games

Comments

@dressupgeekout
Copy link
Owner

For example:

charlotte@dawnchorus:~/devel/lunapurpura/TRICKY/j/IDNav ls -1 *\ .XPK
50031-NAV_EAST_3 .XPK
50074-AN_ODN .XPK
50113-BN_ODN .XPK
50151-CN_ODN .XPK
50190-DN_ODN .XPK
50811-DN_BULTN_2 .XPK
50813-DN_BULTN_4 .XPK

Observe the space character before the dot.

I can confirm this isn't a bug per se, but rather, that's how the file name is actually stored in the PRX. Notice the ASCII 0x20, which is the space character.

4E 41 56 5F 45 41 53 54 5F 33 20 00 00 00 00 00 00 00
N  A  V  _  E  A  S  T  _  3  ' '

Perhaps our PRX reader ought to trim all trailing whitespace unconditionally.

This won't actually affect games from running, this is only a convenience or a concession for human beings extracting individual files.

@dressupgeekout dressupgeekout added BUG Something isn't working ROCKETT Relates to the main Rockett series of games labels Jul 20, 2020
@dressupgeekout dressupgeekout changed the title Some extracted archive members have trailing spaces [Presage] Some extracted archive members have trailing spaces Jul 20, 2020
@dressupgeekout dressupgeekout added ANNOYANCE Not a bug *per se*, but still worth changing and removed BUG Something isn't working labels Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ANNOYANCE Not a bug *per se*, but still worth changing ROCKETT Relates to the main Rockett series of games
Projects
None yet
Development

No branches or pull requests

1 participant