Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clipboard deps #4115

Merged
merged 3 commits into from
Nov 29, 2024
Merged

fix: clipboard deps #4115

merged 3 commits into from
Nov 29, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Nov 21, 2024

close https://github.com/dream-num/univer-pro/issues/2898

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku requested a review from ybzky November 21, 2024 06:42
Copy link

github-actions bot commented Nov 21, 2024

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 18 seconds
commit  1a50e6a
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 33.74%. Comparing base (a5041d2) to head (1a50e6a).
Report is 23 commits behind head on dev.

Files with missing lines Patch % Lines
.../src/controllers/clipboard/clipboard.controller.ts 54.54% 5 Missing ⚠️
packages/sheets-ui/src/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4115   +/-   ##
=======================================
  Coverage   33.74%   33.74%           
=======================================
  Files        2457     2457           
  Lines      127861   127871   +10     
  Branches    28631    28633    +2     
=======================================
+ Hits        43141    43145    +4     
- Misses      84720    84726    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku marked this pull request as ready for review November 21, 2024 07:22
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 21, 2024
@zhaolixin7
Copy link

zhaolixin7 commented Nov 21, 2024

@lumixraku create-another-sheet,复制使用快捷键粘贴仍会进入编辑器
2024_11_21 19_12_20 video.webm

@univer-bot
Copy link

univer-bot bot commented Nov 21, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@lumixraku create-another-sheet, copy and paste using shortcut keys will still enter the editor
2024_11_21 19_12_20 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 21, 2024
@lumixraku lumixraku added the qa:untested This PR is ready to be tested label Nov 21, 2024
@univer-bot univer-bot bot removed the qa:rejected label Nov 21, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 21, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 21, 2024
@lumixraku lumixraku merged commit 57c595e into dev Nov 29, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/clipboard-deps branch November 29, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants