Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue printing out redirected process output after we detect browser launch URL. #44290

Open
wants to merge 2 commits into
base: release/9.0.1xx
Choose a base branch
from
Open

Continue printing out redirected process output after we detect browser launch URL. #44290

wants to merge 2 commits into from
+15 −2

Conversation

tmat
Copy link
Member

@tmat tmat commented Oct 17, 2024 •
edited
Loading

The logic that scans for browser launch URL in the process output stopped forwarding the output after the match has been found. This removes information logged by the web app after that point.

Fixes regression from .NET 8.0.

@tmat tmat requested a review from a team as a code owner October 17, 2024 23:49
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Oct 17, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @tmat.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@tmat
Copy link
Member Author

tmat commented Oct 17, 2024

@davidfowl @eerhardt

@tmat tmat enabled auto-merge October 18, 2024 18:38
@build-analysis build-analysis bot mentioned this pull request Oct 18, 2024
Open
@marcpopMSFT
Copy link
Member

@tmat is this expected for GA and how close is it? I'm checking in on all remaining active 9.0.1xx PRs

@davidfowl
Copy link
Member

Yes this is a regression

This was referenced Oct 19, 2024
Closed
Open
@davidfowl davidfowl linked an issue Oct 19, 2024 that may be closed by this pull request
Dotnet watch pops browser and asks for auth token, but token is never printed to the console #44259
Open
@tmat
Copy link
Member Author

tmat commented Oct 19, 2024

@marcpopMSFT Yes, for GA. Some dotnet new integration tests are intermittently failing in the CI. Restarting and hoping to merge today.

@tmat
Copy link
Member Author

tmat commented Oct 19, 2024

@marcpopMSFT Source build is failing with

Microsoft.DotNet.SourceBuild.SmokeTests.SourceBuiltArtifactsTests.VerifyVersionFile

Assert.Equal() Failure: Strings differ
                  ↓ (pos 7)
Expected: "9.0.100-rtm.24518.1"
Actual:   "9.0.100"

Unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl left review comments

@am11 am11 am11 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dotnet watch pops browser and asks for auth token, but token is never printed to the console
4 participants
@tmat @marcpopMSFT @davidfowl @am11