Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The split between desktop and dotnet msbuild in build.ps1 adds unnecessary complexity to the build #59151

Open
ViktorHofer opened this issue Nov 25, 2024 · 0 comments
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 25, 2024

With #58987, the entire repository can be built with a single build invocation on Windows: eng\build.cmd -msbuildengine vs -restore -all -pack -publish -BuildInstallers (that's what we use in the VMR to build aspnetcore).

The same should be possible when using dotnet msbuild as the entry-point by isolating the components that require desktop msbuild (vcxproj and wixproj) and building them with a shelled-out VS Dev Command Prompt which has desktop msbuild on the path. We do that in dotnet/runtime for similar VS only tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

No branches or pull requests

2 participants