Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and pack symbols for libuv #2898

Closed
JunTaoLuo opened this issue Feb 23, 2018 · 7 comments
Closed

Build and pack symbols for libuv #2898

JunTaoLuo opened this issue Feb 23, 2018 · 7 comments
Labels
enhancement This issue represents an ask for new feature or an enhancement to an existing one

Comments

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Feb 23, 2018

The libuv packages we build do not have any corresponding debug symbols. We should explore how we can produce and pack debug symbols in a libuv symbols package and publish this to the symbols server.

cc @davidfowl @halter73 for libuv expertise
cc @Eilon @muratg for triage
cc @natemcmaster for including additional symbols packages in our build.

@JunTaoLuo JunTaoLuo added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Feb 23, 2018
@halter73
Copy link
Member

Are we going to include the symbols in the main nuget package or on a myget symbol server?

The last time we discussed this, I was told we were saving the old symbols so we could upload them to a symbol server retroactively.

@JunTaoLuo
Copy link
Contributor Author

Apparently we produce these in the libuv-build-windows builds, e.g. $DROPSHARE\libuv-build-windows\dev\10077\build\symbols. We should package these into symbols nupkgs and publish these along with our other symbols.

@davidfowl
Copy link
Member

@JunTaoLuo did we ever look at this?

@JunTaoLuo
Copy link
Contributor Author

Nope we never triaged this. cc @muratg

@Eilon
Copy link
Member

Eilon commented Mar 19, 2018

Should this bug go to one of our libuv repos?

@JunTaoLuo
Copy link
Contributor Author

Yes, and we should do this the next time we build libuv

@muratg
Copy link
Contributor

muratg commented Mar 19, 2018

This issue was moved to aspnet/libuv-build#35

@muratg muratg closed this as completed Mar 19, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Development

No branches or pull requests

5 participants