Add NugetPackageId Metadata to TaskItems #9559
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
approved these changes
Nov 26, 2024
| @@ -192,6 +208,14 @@ void Extract ( | |||
| string resDir = Path.Combine (importsDir, "res"); | |||
| string resDirArchive = Path.Combine (resDir, "..", "res.zip"); | |||
| string assetsDir = Path.Combine (importsDir, "assets"); | |||
| string nuGetPackageId = assemblyItem.GetMetadata (NuGetPackageId) ?? string.Empty; | |||
| string nuGetPackageVersion = assemblyItem.GetMetadata (NuGetPackageVersion) ?? string.Empty; | |||
| Console.WriteLine ($"{assemblyPath}: {nuGetPackageId} {nuGetPackageVersion}"); | |||
There was a problem hiding this comment.
Should it use Log.LogDebugMessage?
There was a problem hiding this comment.
Its draft, I'll be cleaning this up later.
dellis1972
commented
Nov 29, 2024
| @@ -1072,11 +1072,12 @@ To use a custom JDK path for a command line build, set the 'JavaSdkDirectory' MS | |||
| {1} - NuGet package version</comment> | |||
| </data> | |||
| <data name="XA0141" xml:space="preserve"> | |||
| <value>NuGet package '{0}' version '{1}' contains a shared library '{2}' which is not correctly aligned. See https://developer.android.com/guide/practices/page-sizes for more details</value> | |||
| <value>'{2}' from NuGet package '{0}' version '{1}' contains a shared library '{3}' which is not correctly aligned. You may wish to inform the creators of the Library about this issue. See https://developer.android.com/guide/practices/page-sizes for more details.</value> | |||
There was a problem hiding this comment.
@jonpryor can you remember me how we wanted to change this message? I forgot to take notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.