Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Math][Matrix] Support both LookAtRh and LookAtLH or, at least, add the coordinate system in comments or in readme #2286

Open
guiguibubu opened this issue Sep 26, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@guiguibubu
Copy link

Summary of feature

Add support for both coordinate system for LookAt matrix. Like it is in Stride 3D Engine
https://github.com/stride3d/stride/blob/master/sources/core/Stride.Core.Mathematics/Matrix.cs

Or add some comments on the LookAt function to explicitely write the coordinate system. Or/And add it in the readme of the project

Comments

Does this have a proposal?

Check the documentation/proposals folder. If it doesn't have one, you may need to create one if you're making massive breaking changes.

@guiguibubu guiguibubu added the enhancement New feature or request label Sep 26, 2024
@Perksey
Copy link
Member

Perksey commented Oct 16, 2024

Looks like this proposal has defined this, should be implemented with 3.0 generic maths.

@guiguibubu
Copy link
Author

Thanks for the answer !
Is there a branch to help the dev of this proposal ?
I close the issue.

@Perksey
Copy link
Member

Perksey commented Oct 17, 2024

I’ll keep this open until implemented

@Perksey Perksey reopened this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants