Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alder Lake support #342

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Add Alder Lake support #342

wants to merge 22 commits into from

Conversation

tarbaII
Copy link

@tarbaII tarbaII commented Feb 10, 2022

Copied the Comet Lake guide and edited it where needed based on vandroiy2013 and vit9696's reference config they provided me, among other resources.

Note to self and reviewers: SSDT links in ktext.md are placeholders and will be filled in once Getting Started with ACPI is updated. This has been resolved.

Closes dortania/bugtracker#257

Gathering Files SSDT links are placeholders.
@tarbaII tarbaII marked this pull request as draft February 10, 2022 01:23
@tarbaII
Copy link
Author

tarbaII commented Feb 10, 2022

Also edited some things in ktext.md unrelated to Alder Lake.

macos-limits.md Outdated Show resolved Hide resolved
@tarbaII
Copy link
Author

tarbaII commented Feb 10, 2022

Need to figure out how to add the Alder Lake guide to the sidebar at some point, all I did was add the markdown file.

@1Revenger1
Copy link
Member

.vuepress/config.js is where the sidebar is defined..

@tarbaII tarbaII marked this pull request as ready for review February 10, 2022 20:50
@tarbaII
Copy link
Author

tarbaII commented Feb 10, 2022

I'm sure there's still some things that need tweaking, but it's at least in theory finished at this point. Opened up dortania/Getting-Started-With-ACPI#73 as well.

@tarbaII
Copy link
Author

tarbaII commented Feb 11, 2022

@vandroiy2013 Do you happen to know the PciRoot path for the iGPU on Alder Lake? Couldn't find it in your Z690 reference config. I thought it would be a good idea to tell people to set the class-code property to FFFFFFFF in the DeviceProperties section of the config guide since most users would always want it disabled.

@vandroiy2013
Copy link

I suggest to disable IGPU in BIOS and not in DeviceProperties.

@tarbaII tarbaII marked this pull request as draft February 11, 2022 16:44
@tarbaII
Copy link
Author

tarbaII commented Feb 11, 2022

Converted back to a draft since dortania/Getting-Started-With-ACPI#73 should include a section on SSDT-BRG0. Message link

@tarbaII tarbaII marked this pull request as ready for review February 13, 2022 06:57
@tarbaII
Copy link
Author

tarbaII commented Feb 13, 2022

Added an SSDT-BRG0 guide to dortania/Getting-Started-With-ACPI#73. This PR should be ready for review again.

Copy link
Member

@1Revenger1 1Revenger1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine. Left a few small comments.

config.plist/alder-lake.md Outdated Show resolved Hide resolved
config.plist/alder-lake.md Outdated Show resolved Hide resolved
ktext.md Outdated Show resolved Hide resolved
macos-limits.md Outdated Show resolved Hide resolved
Copy link
Member

@dhinakg dhinakg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory review

ktext.md Outdated Show resolved Hide resolved
config.plist/alder-lake.md Outdated Show resolved Hide resolved
config.plist/alder-lake.md Outdated Show resolved Hide resolved
@woefi
Copy link

woefi commented Jul 28, 2022

One last thing I noticed is the boot-arg for the intel 225-v, which is wrongly stated as dk.e1000=0 - should be e1000=0, IMHO.
see: dortania/bugtracker#213 (comment)
In my setup (ASUS Prime Z690-A) Ethernet only stopped panicking after I added this boot-arg.

@tarbaII
Copy link
Author

tarbaII commented Jul 28, 2022

@woefi Yeah, you're right. Pretty sure it was changed in 12.3. I'll change that and make a PR for the rest of the guides at some point. Thanks.

@woefi
Copy link

woefi commented Jan 23, 2023

Hmnn... I wonder why there is still not an "official" section for Alder Lake (or raptor lake fwiw).
I successfully used this guide (and some other infos scattered across the net) over the summer ´22 to build my Asus z690primeA / i5-12600k setup with Monterey. Then over the holidays updated to Ventura (13.1) and since then the only big problem for me is the ethernet panicking if plugged in (i225-V).

Because I'm not 100% confident about ALL of the parts of my EFI I would like to check against an "officially supported" guide.
Is there anything I could help with to speed this up?

@kimrenea
Copy link

Hmnn... I wonder why there is still not an "official" section for Alder Lake (or raptor lake fwiw). I successfully used this guide (and some other infos scattered across the net) over the summer ´22 to build my Asus z690primeA / i5-12600k setup with Monterey. Then over the holidays updated to Ventura (13.1) and since then the only big problem for me is the ethernet panicking if plugged in (i225-V).

Because I'm not 100% confident about ALL of the parts of my EFI I would like to check against an "officially supported" guide. Is there anything I could help with to speed this up?

I second this. Would be nice to have an official section for Alder Lake. I followed the guide all the way to ACPI, but then there's nothing after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alder Lake & Rocket Lake
6 participants