Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alder Lake and Rocket Lake support #73

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

tarbaII
Copy link

@tarbaII tarbaII commented Feb 10, 2022

Not finished as of the time of writing. More commits coming soon.
Edit: Ready for review.

@tarbaII tarbaII marked this pull request as draft February 10, 2022 20:00
@tarbaII tarbaII marked this pull request as ready for review February 10, 2022 20:51
@tarbaII tarbaII marked this pull request as draft February 11, 2022 16:44
@tarbaII
Copy link
Author

tarbaII commented Feb 11, 2022

This PR should have a section on SSDT-BRG0, but I'm pretty underqualified for that as I hear there's a bit of nuance to it on different platforms. Help is much appreciated.

@tarbaII
Copy link
Author

tarbaII commented Feb 12, 2022

@vandroiy2013 If you have time at some point, could you take a screenshot of IOReg with GFX0 (or whatever your GPU's name is) selected, and another screenshot of the pci-bridge that GFX0 is connected to selected? If you can't, that's fine of course.

@vandroiy2013
Copy link

Sure

Снимок экрана 2022-02-12 в 11 30 55

@tarbaII tarbaII marked this pull request as ready for review February 13, 2022 06:56
@tarbaII
Copy link
Author

tarbaII commented Feb 13, 2022

Tried to make an SSDT-BRG0 guide. If there's any issues with it, leave a review of course.

@tarbaII tarbaII changed the title Add Alder Lake support Add Alder Lake and Rocket Lake support Feb 13, 2022
Universal/brg0-methods/manual.md Outdated Show resolved Hide resolved
Universal/brg0-methods/manual.md Outdated Show resolved Hide resolved
Universal/usbw.md Outdated Show resolved Hide resolved
@tarbaII tarbaII requested a review from dhinakg November 7, 2022 16:34

## What this SSDT does

SSDT-USBW is a companion to the [USBWakeFixup kext](https://github.com/osy/USBWakeFixup), which addresses USB wake issues on certain Intel platforms. Do not use this SSDT unless you have the USBWakeFixup kext.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a last resort when adding acpi-wake-type doesn't work. Could you maybe explain a bit more about what is going on here and other prerequisites?

Universal/brg0.md Show resolved Hide resolved

To get SSDT-BRG0, run the following:

* `7. Dump DSDT` then run `9. PCI Bridge`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain how to get a device path, and which devices this should be done for.

Universal/brg0.md Outdated Show resolved Hide resolved
Co-authored-by: Avery Black <[email protected]>

* [SSDT-USBW.aml](https://github.com/dortania/Getting-Started-With-ACPI/blob/master/extra-files/compiled/SSDT-USBW.aml)

This prebuilt file is just a precompiled version of [SSDT-USBW](https://raw.githubusercontent.com/osy/USBWakeFixup/master/SSDT-USBW.dsl).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just providing the prebuilt method here is fine, since the decompiled version is linked here.

Universal/plug-alt.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants