Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steal-stache/can missing after add component #310

Open
janat08 opened this issue Oct 16, 2019 · 8 comments
Open

steal-stache/can missing after add component #310

janat08 opened this issue Oct 16, 2019 · 8 comments
Labels

Comments

@janat08
Copy link

janat08 commented Oct 16, 2019

if having generator add dependencies is out of scope at least edit the guide https://donejs.com/plugin.html#show-it-off
or have the plugin generator add these dependencies

@matthewp
Copy link
Contributor

Thanks for filing @janat08 ! I don't quite understand the problem. Are you saying that steal-stache and can are removed as dependencies after running donejs add component my-component?

@janat08
Copy link
Author

janat08 commented Oct 16, 2019

No, nothing ever adds those dependencies.

@cherifGsoul
Copy link
Contributor

@janat08 Do you mean the guide should show how to add canjs dependencies, or install those dependencies when generating a plugin?
If yes, what if the plugin doesn't use canjs?

@janat08
Copy link
Author

janat08 commented Dec 26, 2019

I don't know anymore.

@janat08 janat08 closed this as completed Dec 26, 2019
@phillipskevin
Copy link
Contributor

I think what we should confirm is you can:

  1. donejs add plugin
  2. donejs add component my-component
  3. confirm the package.json has can and steal-stache as dependencies
  4. confirm the package.json has steal-stache as a steal plugin like https://github.com/canjs/canjs/blob/175036d7376a88eb5fc5e6f550066d64c52493ad/package.json#L219-L221

If those are true, we can re-close.

@phillipskevin phillipskevin reopened this Dec 27, 2019
@cherifGsoul
Copy link
Contributor

As listed by @phillipskevin in the steps above, the 3 and 4 step are not running as expected.

@cherifGsoul
Copy link
Contributor

cherifGsoul commented Jan 22, 2020

I can confirm it adds steal-stache as dependency, not as I mentioned in the comment above.

For the canjs packages dependencies the plugin generator has dependencies option when creating the plugin but it seems is not working.

.withOptions({
packages: {
dependencies: {
"can-component": "^3.0.4",
"can-define": "^1.0.10",
"can-stache": "^3.0.16",
"can-view-autorender": "^3.0.4",
"steal-less": "^1.2.0",
"steal-stache": "^3.0.5"

@cherifGsoul
Copy link
Contributor

cherifGsoul commented Jan 23, 2020

When I try to generate a plugin with dependencies:

$ donejs add plugin --dependencies can-define can-component can-stache
error: unknown option `--dependencies'

The same with packages option:

$ donejs add plugin --packages can-define can-component can-stache
error: unknown option `--dependencies'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants