Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator should follow the debugging guide by include include the name/tag as the 0th argument to extended DefineMap (the view model) #283

Open
mjstahl opened this issue Mar 13, 2018 · 0 comments

Comments

@mjstahl
Copy link
Contributor

mjstahl commented Mar 13, 2018

The debugging guide recommends naming your DefineMaps by putting a string in the 0th argument of the .extend.

The app generator includes a conditional import for can-debug. This implies that we should be using the new debugging features.

But when I generate a new component, the view model does not include a name for the DefineMap as recommended by the guide.

Per a discussion on slack, we should camelcase the tag (after removing the -) and maybe add VM at the end. (like so - https://github.com/canjs/can-component/blob/311a68be00f9d7a5ce74f2e68f75ddfbffb1ffef/can-component.js#L175)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant