Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.stache, development.html should link to steal-sans-promises.js #266

Open
mjstahl opened this issue Oct 23, 2017 · 1 comment
Open

Comments

@mjstahl
Copy link
Contributor

mjstahl commented Oct 23, 2017

Description:
In a newly generated app, development.html and in index.stache where the environment is not production, should reference steal-sans-promises.js, not steal.js.

The reasoning here is the promise shim really messes with the stack, and people are most likely developing with a modern browser because they have the best tools. Production should offer the application to the widest possible audience (with the promise shim for browsers like IE11).

Environment:

Software Version
donejs -V 1.0.1
npm ls generator-donejs 1.0.7
@chasenlehara
Copy link
Member

I wonder if it’s a bug that the shim is even used in newer browsers; seems like we’d want to default to the native implementation if it’s there, and only shim if it’s not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants