Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows file paths for dropping databases #7494

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Feb 14, 2024

We have to convert windows file path separators to unix ones, when removing them from singleton cache.

Additionally, unskips some bats tests

Fixes #7492

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
99.999562 to 99.999562
version result total
c0dba84 not ok 26
c0dba84 ok 5937431
version total_tests
c0dba84 5937457
correctness_percentage
99.999562

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jycor jycor merged commit 4849f99 into main Feb 14, 2024
21 of 22 checks passed
@jycor jycor deleted the james/windows-file branch February 14, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants