Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mapping driver tests #2354

Closed
2 tasks
IonBazan opened this issue Aug 5, 2021 · 2 comments
Closed
2 tasks

Refactor mapping driver tests #2354

IonBazan opened this issue Aug 5, 2021 · 2 comments

Comments

@IonBazan
Copy link
Member

IonBazan commented Aug 5, 2021

Change Request

Mapping drivers tests should be refactored to reduce code duplication and make sure that all mapping features are tested for each driver and the derived tests for each driver contain only the driver-specific assertions (all general assertions should be in base test cases).

  • Merge tests from tests/Doctrine/ODM/MongoDB/Tests/Mapping/Driver/AbstractDriverTest.php and tests/Doctrine/ODM/MongoDB/Tests/Mapping/AbstractMappingDriverTest.php and put fixture documents in separate files
  • Merge tests/Doctrine/ODM/MongoDB/Tests/Mapping/AbstractAnnotationDriverTest.php into tests/Doctrine/ODM/MongoDB/Tests/Mapping/AbstractMappingDriverTest.php
@stale
Copy link

stale bot commented Sep 6, 2021

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues that have not seen any activity in 30 days label Sep 6, 2021
@franmomu franmomu removed the Stale Issues that have not seen any activity in 30 days label Sep 8, 2021
@IonBazan
Copy link
Member Author

Closing as duplicate of #2348. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants