Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Replace "All users" with "Everyone" #6091

Open
2 of 4 tasks
Timo-Breumelhof opened this issue Jul 3, 2024 · 5 comments
Open
2 of 4 tasks

[Enhancement]: Replace "All users" with "Everyone" #6091

Timo-Breumelhof opened this issue Jul 3, 2024 · 5 comments

Comments

@Timo-Breumelhof
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description of problem

Please read: https://dnncommunity.org/forums/future-development/dnn-ideas/quotall-usersquot-is-not-the-best-term-for-security/

Description of solution

Use "Everyone" instead of "All Users" as text for that "virtual role"

Description of alternatives considered

All visitors, but most seem to prefer "Everyone", see Forum Thread.

Anything else?

No response

Do you be plan to contribute code for this enhancement?

  • Yes

Would you be interested in sponsoring this enhancement?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Timo-Breumelhof
Copy link
Contributor Author

Hmm, seems to be quite a change if I look at the code..

@sleupold
Copy link
Contributor

sleupold commented Jul 4, 2024

You should chenge just the localization value of Key AllUsers.text in App_GlobalRessources/SharedResources.resx file.

@Timo-Breumelhof
Copy link
Contributor Author

The Persona Bar ignores that localized string, does work in module settings

@sleupold
Copy link
Contributor

sleupold commented Jul 4, 2024

Timo, you are correct - but this is a separate bug IMHO.
It shoould use localized values as well.

@Timo-Breumelhof
Copy link
Contributor Author

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants