Skip to content

Latest commit

 

History

History
68 lines (50 loc) · 5.23 KB

CONTRIBUTING.md

File metadata and controls

68 lines (50 loc) · 5.23 KB
Raw

Contributing to Gulp Sass

gulp-sass is a very light-weight wrapper around either Dart Sass or Node Sass (which in turn is a Node binding for LibSass. All of these are implementations of the Sass language.

Submitting Issues

  • Before creating a new issue, perform a cursory search in the Gulp Sass, Dart Sass, Node Sass, Libsass, and main Sass repos to see if a similar issue has already been submitted. Please also refer to our Common Issues and Their Fixes page for some basic troubleshooting.
  • You can create an issue here. Please include as many details as possible in your report.
  • Issue titles should be descriptive, explaining at the high level what it is about.
  • Please include the version of gulp-sass, Node, and NPM you are using, as well as what operating system you are having a problem on.
  • Do not open a pull request to resolve an issue without first receiving feedback from a collaborator or owner and having them agree on a solution forward.
  • Include screenshots and animated GIFs whenever possible; they are immensely helpful.
  • Issues that have a number of sub-items that need to be complete should use task lists to track the sub-items in the main issue comment.

Pull Requests

  • DO NOT ISSUE A PULL REQUEST WITHOUT FIRST SUBMITTING AN ISSUE
  • Pull requests should reference their related issues. If the pull request closes an issue, please reference its closing in your commit messages. Pull requests not referencing any issues will be closed.
  • Pull request titles should be descriptive, explaining at the high level what it is doing, and should be written in the same style as Git commit messages.
  • Update the CHANGELOG with the changes made by your pull request, making sure to use the proper Emoji.
  • Follow our JavaScript styleguides. Tests will fail if you do not.
  • Ensure that you have EditorConfig installed in your editor of choice and that it is functioning properly.
  • Do not squash or rebase your commits when submitting a Pull Request. It makes it much harder to follow your work and make incremental changes.
  • Update the CHANGELOG with your changes.
  • Branches should be made off of the most current master branch from [email protected]:dlmanning/gulp-sass.git
  • Pull requests should be made into our master branch.

Git Commit Messages

  • Use the present tense ("Add feature" not "Added Feature")
  • Use the imperative mood ("Move cursor to…" not "Moves cursor to…")
  • Limit the first line to 72 characters or less
  • Consider including relevant Emoji from our Emoji cheatsheet

Creating a New Version

Versioning is done through SEMVER. When creating a new version, create new release branch off of master with the version's name, and create a new tag with v prefixed with the version's name from that branch.

For instance, if you are creating version 1.1.0, you would create a branch release/1.1.0 from master and create a tag v1.1.0 from branch release/1.1.0.

Maintaining the Changelog

The Changelog should have a list of changes made for each version. They should be organized so additions come first, changes come second, and deletions come third. Version numbers should be 2nd level headers with the v in front (like a tag) and the date of the version's most recent update should be underneath in italics.

Changelog messages do not need to cover each individual commit made, but rather should have individual summaries of the changes made. Changelog messages should be written in the same style as Git commit messages.

Emoji Cheatsheet

When creating creating commits or updating the CHANGELOG, please start the commit message or update with one of the following applicable Emoji. Emoji should not be used at the start of issue or pull request titles.

  • 🎨 :art: when improving the format/structure of the code
  • 🐎 :racehorse: when improving performance
  • 📝 :memo: when writing long-form text (documentation, guidelines, principles, etc…)
  • 🐛 :bug: when fixing a bug
  • 🔥 :fire: when removing code or files
  • 💚 :green_heart: when fixing the CI build
  • ✅ :white_check_mark: when adding tests
  • 🔒 :lock: when dealing with security
  • ⬆️ :arrow_up: when upgrading dependencies
  • ⬇️ :arrow_down: when downgrading dependencies
  • 👕 :shirt: when removing linter warnings
  • :shipit: :shipit: when creating a new release