Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New task form: need to reset VDAF parameters when changing VDAF type #999

Open
divergentdave opened this issue Apr 22, 2024 · 0 comments
Open

Comments

@divergentdave
Copy link
Contributor

When the vdaf.type field is changed in the new task form, we need to both clear any nested parameters that don't apply to the new VDAF, and set default values of VDAF parameters to mirror the default values of their controls. Currently, if you change the "Function" selector to "sum" and don't touch the "Measurement Range" selector, the request will only include a type within the vdaf nested object. Moreover, the API error (below) is not surfaced as a validation error in the UI.

{
	"vdaf": {
		"bits": [
			{
				"code": "required",
				"message": null,
				"params": {
					"value": null
				}
			}
		]
	}
}

Furthermore, if you change the function to "histogram", enter some histogram buckets, and then change the function to "sum", the histogram buckets will still be sent to the server in the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant