CLS 82 add endpoint for getting pf bs for namespace #135

vvuwei · 2023-10-17T19:23:38Z

added logic on selecting msgs by type on namespace
update usage of Messages method
updated logic of namespace.GetMessages handler, added unit tests

aopoltorzhicky · 2023-10-17T19:29:27Z

cmd/api/handler/namespace.go

@@ -290,7 +293,13 @@ func (handler *NamespaceHandler) GetMessages(c echo.Context) error {
 		return err
 	}

-	messages, err := handler.namespace.Messages(c.Request().Context(), ns.Id, int(req.Limit), int(req.Offset))
+	var msgType *storageTypes.MsgType
+	msgT, err := storageTypes.ParseMsgType(req.Type)


А что будет, если в параметр написать невалидное значение типа? Он выставит тип, как будто его нет. Валидации у нас разве нет?

vvuwei · 2023-10-17T19:37:40Z

canceled - feature does not needed.

vvuwei added 4 commits October 17, 2023 21:50

added logic on selecting msgs by type on namespace

f6abacb

update usage of Messages method

9baf5ce

updated logic of namespace.GetMessages handler, added unit tests

fc6191b

updated api docs

15804cf

vvuwei requested a review from aopoltorzhicky October 17, 2023 19:24

vvuwei self-assigned this Oct 17, 2023

vvuwei added the enhancement New feature or request label Oct 17, 2023

vvuwei added this to the v1.0.0 milestone Oct 17, 2023

aopoltorzhicky requested changes Oct 17, 2023

View reviewed changes

vvuwei closed this Oct 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLS 82 add endpoint for getting pf bs for namespace #135

CLS 82 add endpoint for getting pf bs for namespace #135

vvuwei commented Oct 17, 2023

aopoltorzhicky Oct 17, 2023

vvuwei commented Oct 17, 2023

CLS 82 add endpoint for getting pf bs for namespace #135

CLS 82 add endpoint for getting pf bs for namespace #135

Conversation

vvuwei commented Oct 17, 2023

aopoltorzhicky Oct 17, 2023

Choose a reason for hiding this comment

vvuwei commented Oct 17, 2023