Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add category parameter to DangerXcodeSummary::Result #46

Open
yhkaplan opened this issue Jul 17, 2019 · 1 comment
Open

Add category parameter to DangerXcodeSummary::Result #46

yhkaplan opened this issue Jul 17, 2019 · 1 comment

Comments

@yhkaplan
Copy link

I would like to improve the ergonomics of Result by adding a parameter called type or category that specifies whether it's a build error, failing test, warning, etc. This would make setting the ignored_results block much easier. What do you think? If you like the idea, I'll submit a PR!
@diogot
Copy link
Owner

diogot commented Jul 26, 2019

I like the idea, feel free to submit a PR.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diogot @yhkaplan