Removecontainernode

[stringa]

I removed the need for container node.

stringa

[tonistiigi]

Doesn't this affect transitions and possibly node trees that use custom anchorpoints?

I'll make a proper review in couple of days.

[stringa]

It shouldn't affect hierarchy since this gets set all the way up the tree.
As for transitions... I will look at that. The position gets modified
before the transition is set.
On Jun 6, 2014 12:36 AM, "Tõnis Tiigi" [email protected] wrote:

Doesn't this affect transitions and possibly node trees that use custom
anchorpoints?

I'll make a proper review in couple of days.

—
Reply to this email directly or view it on GitHub
#142 (comment).

[stringa]

I would appreciate a review of this code sometime soon.

Thanks,
stringa

[tonistiigi]

Just something that I quickly noticed. Run shapes2 demo. When you click on the shapes, stroke is added. With this patch the child offsets change. Also when switching to canvas mode child nodes don't appear on correct locations.

Also, can you rebase to currect master. As I understand only the last commit contains the relevant change and everything else is already merged.

[stringa]

No problem. I will look at all these issues and give you an update.

Sean
On Jun 12, 2014 2:04 PM, "Tõnis Tiigi" [email protected] wrote:

Just something that I quickly noticed. Run shapes2 demo. When you click on
the shapes stroke is added. With this patch the child offsets change. Also
when switching to canvas mode child nodes don't appear on correct locations.

Also, can you rebase to currect master. As I understand only the last
commit contains the relevant change and everything else is already merged.

—
Reply to this email directly or view it on GitHub
#142 (comment).

[stringa]

Borders are funny. They change the attachment point of the children. I would have to set all the children dirty and take into account the border size in order to get this correct. I'm not sure this will work when using CSS Transitions. I am going to fix this in my matrix3d branch where there is no more CSS Transitions.