Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom var name for with statement and nesting of files. #759

Merged
merged 8 commits into from
Nov 17, 2024

Conversation

liz3
Copy link
Contributor

@liz3 liz3 commented Nov 17, 2024

feat: allow custom var name for with statement and nesting of files.

What's Changed:

This refactors the logic in the compiler to allow files to have
custom variable names and also allow the nesting of multiple files
within each other. Both of which should be possible.
The latter is a bit questionable in terms of code quality but needed anyways.

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

liz3 added 4 commits November 17, 2024 00:58
This refactors the logic in the compiler to allow files to have
custom variable names and also allow the nesting of multiple files
within each other. Both of which should be possible.
The latter is a bit questionable in terms of code quality but needed anyways.
@liz3 liz3 changed the title feat: allow custom var name for with and nesting of files. feat: allow custom var name for with statement and nesting of files. Nov 17, 2024
docs/docs/files.md Outdated Show resolved Hide resolved
docs/docs/files.md Outdated Show resolved Hide resolved
src/vm/compiler.c Outdated Show resolved Hide resolved
liz3 and others added 3 commits November 17, 2024 18:33
@liz3
Copy link
Contributor Author

liz3 commented Nov 17, 2024

Oh btw @Jason2605 do you have a email address or something i can contact you outside of github?

@Jason2605
Copy link
Member

Thanks for this!

Of course my friend: [email protected]

@Jason2605 Jason2605 merged commit bce42e8 into dictu-lang:develop Nov 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants