Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes in this PR, weapon explosions only do the collision check once, in
AddWeaponExplosion()
. I set thedontDeleteOnCollision
flag to prevent the missile from immediately deleting itself. This means the missile animation will always play to completion regardless of whether the elemental damage strikes the target.I modified
DoAttack()
to use thedidhit
flag to determine whether the missile should attempt to do damage to the target. Just like with elemental arrows, if the physical attack doesn't hit, the elemental attack doesn't hit either. In order to skip the collision check but still play the missile animation,DoAttack()
simply sets the missile damage to zero if the physical attack missed.AddWeaponExplosion()
will skip the collision check entirely if it sees that the missile damage is zero.This resolves #7571