Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cathedral wall corners use the wrong tile #7504

Open
kphoenix137 opened this issue Nov 2, 2024 · 4 comments
Open

Cathedral wall corners use the wrong tile #7504

kphoenix137 opened this issue Nov 2, 2024 · 4 comments
Labels
vanilla Bugs found also in the original Diablo 1.09b release

Comments

@kphoenix137
Copy link
Collaborator

Operating System

Windows x64

DevilutionX version

1.5.3

Describe

Vanilla:
image

Suggested fix:
image

To Reproduce

N/A

Expected Behavior

No response

Additional context

No response

@AJenbo AJenbo added the vanilla Bugs found also in the original Diablo 1.09b release label Nov 2, 2024
@julealgon
Copy link
Contributor

Nice find. Is the issue only related to the cut left arch, or is there more to it I've not noticed?

I can see the slightly different tiling pattern at the top but that seems inconsequential.

@AJenbo
Copy link
Member

AJenbo commented Nov 4, 2024

Nice find ... but that seems inconsequential.

your welcome

@julealgon
Copy link
Contributor

@AJenbo you need to improve your English interpretation skills man...

I was saying the difference in tiling at the top of the wall was inconsequential (as in, it changed, but it was ok), while fully acknowledging the (much larger and more obvious) difference in the way the left arch was cut by the wall.

@AJenbo
Copy link
Member

AJenbo commented Nov 4, 2024

I was saying the difference in tiling at the top of the wall was inconsequential (as in, it changed, but it was ok), while fully acknowledging the (much larger and more obvious) difference in the way the left arch was cut by the wall.

Ok that wasn't really clear from your original phasing. To clarify the issue is that the level generator uses a horizontal wall end piece instead of a corner piece when connecting walls. The change to the top of the tile is also part of the correction as it changes it from a fall off shadow on the wall edge to the bricks instead connecting inside the corner.

The fix should be trivial but we do need to make sure that later pattern fixes do not mistakenly rely on this mistake, if so they should also be corrected.

image

image

@AJenbo AJenbo changed the title [Issue Report]: Wall corners use wrong tile Cathedral wall corners use the wrong tile Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vanilla Bugs found also in the original Diablo 1.09b release
Projects
None yet
Development

No branches or pull requests

3 participants