Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyctl install not working without specifying specific version #25

Open
GMkonan opened this issue Sep 15, 2023 · 3 comments
Open

Flyctl install not working without specifying specific version #25

GMkonan opened this issue Sep 15, 2023 · 3 comments

Comments

@GMkonan
Copy link

GMkonan commented Sep 15, 2023

If you pass "latest", "lts" or nothing at all the installation will fail. Problem is probably at this line.
https://github.com/dhoeric/features/blob/192d4a726534537fb24b0caeedf9bf689ce72b41/src/flyctl/install.sh#L51C18-L51C18

This is because flyctl changed how they name their tags as you can see here:

Using the same git ls-remote --tags https://github.com/superfly/flyctl command

image

So now instead of getting the version number (E.g. v0.1.92) We are getting 2023.9.8

@nikolayv
Copy link

+1. Also ran into this yesterday.

@GMkonan's diagnosis is correct. They switched their tags a few days ago, but kept naming their outputs as before. https://github.com/superfly/flyctl/releases/tag/v2023.9.8

@GMkonan
Copy link
Author

GMkonan commented Sep 20, 2023

Created a pull request that I think solves the issue. Not sure if it's gonna get merged since this repo doesn't see an update for a while.

@oscarhermoso
Copy link

Saving the next person a minute to figure out the work-around, you can update your devcontainer.json with the following:

"features": {
      "ghcr.io/dhoeric/features/flyctl:1": {
	      // Must be manually specified because of: https://github.com/dhoeric/features/issues/25
	      // Find new version with: curl -s https://api.github.com/repos/superfly/flyctl/releases/latest | jq -r '.tag_name'
	      "version": "0.1.121"
      }
},
// bonus points, include fly.io credentials:
"mounts": [
    "source=${localEnv:HOME}${localEnv:USERPROFILE}/.fly,target=/home/vscode/.fly,type=bind,consistency=cached"
], // save creds to home dir of container user, eg. vscode/node/root  ^^^^^^ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants