-
Notifications
You must be signed in to change notification settings - Fork 29
Conversation
Signed-off-by: Valeriy Svydenko <[email protected]>
devfile.yaml
Outdated
@@ -4,7 +4,7 @@ metadata: | |||
components: | |||
- name: tooling-container | |||
container: | |||
image: quay.io/devspaces/ansible-creator-ee@sha256:a1d053d24f0b80438568bd4e06437900f0afe0ae29fcfa749bbace5cfff8c2ca | |||
image: ghcr.io/ansible/community-ansible-devspaces:latest@sha256:42af3f305fd9b19d1493099723c95cba3127b67a0d703b75a7cae4e362ddfea6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does ghcr.io has any pull limits ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the comment here - it seems to not have one for public repos.
@NilashishC could you please comment on this |
ghcr.io/ansible/community-ansible-devspaces:latest@sha256:42af3f305fd9b19d1493099723c95cba3127b67a0d703b75a7cae4e362ddfea6 image doesn't exist anymore, need to figure out |
Signed-off-by: Valeriy Svydenko <[email protected]>
FYI: The latest SHA has changed. We did a new release 4 days back. |
@NilashishC We can't use image with tag in Dev Spaces sample, it should be SHA that is not going to be change. Since https://github.com/ansible/ansible-workspace-env-reference-image/pkgs/container/ansible-workspace-env-reference/211507328?tag=latest provides only latest tag, we don't have stable SHA. @dmytro-ndp As far as I remember we have some verification that all images contain SHA instead of tag in Dev Spaces, am I right? |
you are right To enable OpenShift image mirroring in an airgapped environment, it's necessary to use the sha256 hash in the image address. |
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
I'd like to get a review from @dmytro-ndp |
@svor : I have tested recommended extensions installation, devfile command run and ansible playbook code auto-completion in workspace created from https://github.com/devspaces-samples/ansible-devspaces-demo/tree/sv-new-community-image repo on workspaces.openshift.com, and in Dev Spaces 3.14.0.ER. Everything worked as expected, except for one instance of workspace startup failure that I couldn't reproduce a second time: The note: what do you think about enabling Ansible Lightspeed in Ansible extension by default, in order to avoid |
@dmytro-ndp thank you for the review
I can't reproduce this problem on my side
It's a great idea, issue for this improvement: https://issues.redhat.com/browse/CRW-6336 |
@svor : thanks for the heads up! In fact, I couldn't reproduce start workspace error |
Replace dev image with new Community Ansible Dev Spaces Image
Related issue: https://issues.redhat.com/browse/CRW-6290
To test current changes: