Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

feat: use new community image #28

Merged
merged 5 commits into from
May 10, 2024
Merged

Conversation

svor
Copy link
Collaborator

@svor svor commented Apr 29, 2024

Replace dev image with new Community Ansible Dev Spaces Image

screenshot-devspaces apps sandbox-m4 g2pi p1 openshiftapps com-2024 04 29-12_16_09

Related issue: https://issues.redhat.com/browse/CRW-6290

To test current changes:

  1. Login into https://workspaces.openshift.com
  2. Start a workspace by clicking the icon below
    Contribute
  3. Check that all functionality works as expected

Signed-off-by: Valeriy Svydenko <[email protected]>
@svor svor self-assigned this Apr 29, 2024
@svor
Copy link
Collaborator Author

svor commented Apr 29, 2024

cc @kyetter @dmytro-ndp @NilashishC

devfile.yaml Outdated
@@ -4,7 +4,7 @@ metadata:
components:
- name: tooling-container
container:
image: quay.io/devspaces/ansible-creator-ee@sha256:a1d053d24f0b80438568bd4e06437900f0afe0ae29fcfa749bbace5cfff8c2ca
image: ghcr.io/ansible/community-ansible-devspaces:latest@sha256:42af3f305fd9b19d1493099723c95cba3127b67a0d703b75a7cae4e362ddfea6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does ghcr.io has any pull limits ?

Copy link

@NilashishC NilashishC Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the comment here - it seems to not have one for public repos.

@bontreger
Copy link

bontreger commented Apr 29, 2024

Can we rebase off the downstream UDI-rhel8? or explain the 2gb difference. We're dealing with some significant container-size bloat that causes performance and startup timeout issues on slower/throttled connections

image

@svor
Copy link
Collaborator Author

svor commented Apr 30, 2024

Can we rebase off the downstream UDI-rhel8? or explain the 2gb difference. We're dealing with some significant container-size bloat that causes performance and startup timeout issues on slower/throttled connections

image

@NilashishC could you please comment on this

@svor
Copy link
Collaborator Author

svor commented May 2, 2024

ghcr.io/ansible/community-ansible-devspaces:latest@sha256:42af3f305fd9b19d1493099723c95cba3127b67a0d703b75a7cae4e362ddfea6 image doesn't exist anymore, need to figure out

@svor svor marked this pull request as draft May 2, 2024 13:42
Signed-off-by: Valeriy Svydenko <[email protected]>
@NilashishC
Copy link

@svor
Copy link
Collaborator Author

svor commented May 7, 2024

@NilashishC We can't use image with tag in Dev Spaces sample, it should be SHA that is not going to be change. Since https://github.com/ansible/ansible-workspace-env-reference-image/pkgs/container/ansible-workspace-env-reference/211507328?tag=latest provides only latest tag, we don't have stable SHA.

@dmytro-ndp As far as I remember we have some verification that all images contain SHA instead of tag in Dev Spaces, am I right?

@dmytro-ndp
Copy link

dmytro-ndp commented May 7, 2024

@svor

@dmytro-ndp As far as I remember we have some verification that all images contain SHA instead of tag in Dev Spaces, am I right?

you are right

To enable OpenShift image mirroring in an airgapped environment, it's necessary to use the sha256 hash in the image address.

svor added 3 commits May 8, 2024 19:58
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
@svor svor marked this pull request as ready for review May 8, 2024 17:45
@svor
Copy link
Collaborator Author

svor commented May 8, 2024

I'd like to get a review from @dmytro-ndp

@dmytro-ndp
Copy link

dmytro-ndp commented May 9, 2024

@svor : I have tested recommended extensions installation, devfile command run and ansible playbook code auto-completion in workspace created from https://github.com/devspaces-samples/ansible-devspaces-demo/tree/sv-new-community-image repo on workspaces.openshift.com, and in Dev Spaces 3.14.0.ER.

Everything worked as expected, except for one instance of workspace startup failure that I couldn't reproduce a second time: Error creating DevWorkspace deployment: Container tooling-container has starte ImagePullBackOff

Screenshot from 2024-05-09 15-14-15

The note: what do you think about enabling Ansible Lightspeed in Ansible extension by default, in order to avoid Enable lightspeed services from settings to use the feature. error when try to connect to Ansible Lightspeed:

screenshot-devspaces apps sandbox-m4 g2pi p1 openshiftapps com-2024 05 09-14_36_37

@svor
Copy link
Collaborator Author

svor commented May 9, 2024

@dmytro-ndp thank you for the review

Error creating DevWorkspace deployment: Container tooling-container has starte ImagePullBackOff

I can't reproduce this problem on my side

The note: what do you think about enabling Ansible Lightspeed in Ansible extension by default, in order to avoid Enable lightspeed services from settings to use the feature. error when try to connect to Ansible Lightspeed:

It's a great idea, issue for this improvement: https://issues.redhat.com/browse/CRW-6336

@dmytro-ndp
Copy link

dmytro-ndp commented May 10, 2024

@svor : thanks for the heads up!

In fact, I couldn't reproduce start workspace error Error creating DevWorkspace deployment: Container tooling-container has state ImagePullBackOff on the same cluster or on another cluster.

@svor svor merged commit 0575193 into devspaces-3-rhel-8 May 10, 2024
1 check passed
@svor svor deleted the sv-new-community-image branch May 10, 2024 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants