Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desi_compute_bias requires unsetting $DESI_SPECTRO_DARK #2399

Open
sbailey opened this issue Oct 25, 2024 · 1 comment · May be fixed by #2405
Open

desi_compute_bias requires unsetting $DESI_SPECTRO_DARK #2399

sbailey opened this issue Oct 25, 2024 · 1 comment · May be fixed by #2405

Comments

@sbailey
Copy link
Contributor

sbailey commented Oct 25, 2024

To create a new bias with desi_compute_bias, you first have to unset DESI_SPECTRO_DARK, or otherwise it fails due to not finding the bias file that you are trying to create in the first place.

I did not find this procedure documented, but I have a vague memory of @julienguy mentioning needing to do this. We should fix this so that "missing" biases and darks are only fatal if the processing is actually needs that bias/dark.

@Waelthus
Copy link
Contributor

Waelthus commented Nov 5, 2024

I confirm the issue, and I think it was introduced when we disallowed calibfinder to run with darks in DESI_SPECTRO_CALIB for normal analyses. So I guess the PR above will fix this behaviour by allowing a fallback when run as part of ccdcalib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants